fix: close WebSocket on pagehide to support bfcache#162
Open
fix: close WebSocket on pagehide to support bfcache#162
Conversation
Dobrunia
approved these changes
Feb 13, 2026
neSpecc
reviewed
Feb 13, 2026
There was a problem hiding this comment.
Pull request overview
Updates the JavaScript Socket transport to close its WebSocket connection on pagehide, enabling the page to enter the browser back/forward cache (bfcache) and addressing Lighthouse warnings.
Changes:
- Adds a
pagehideevent handler that closes the WebSocket. - Registers/unregisters the
pagehidelistener when the socket opens/closes. - Introduces an internal
close()helper to null out the socket after closing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original problem
Lighthouse was giving an exception "Pages with WebSocket cannot enter back/forward cache (bfcache)" because we were not closing socket on
pagehideevent.PR Description
Solution from MDN reference was implemented. When reproducing notice that
vite devalso opens a socket, so, instead usenpx vite buildwithnpx serveand import changing inindex.html.pageshowevent is ignored, because socket connection will be restored when send method will be called.